Skip to content

[V1][Draft] Jump-forward decoding #15490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[V1][Draft] Jump-forward decoding #15490

wants to merge 2 commits into from
+110 −55

Conversation

aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Mar 25, 2025 •
edited by github-actions bot
Loading

This PR aims to add support for jump-forward decoding by introducing the following API:

  • For Grammar class:
    • jump_forward_string: returns the longest jf-able string from the FSM
    • find_token_divergence: returns the index of shared outputs ids between (prev_output) and (prev_output+jf_string) and handle FSM accordingly

--wip--

Signed-off-by: Aaron Pham [email protected]

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 25, 2025
@aarnphm
Copy link
Collaborator Author

aarnphm commented Mar 26, 2025

Will ping once it is ready, discussing with Yixin atm to clear up some confusion

@mergify mergify bot added tpu Related to Google TPUs and removed tpu Related to Google TPUs labels Mar 27, 2025
@mergify Mergify
Copy link

mergify bot commented Apr 1, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @aarnphm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 1, 2025
@mergify mergify bot added tpu Related to Google TPUs and removed tpu Related to Google TPUs labels Apr 9, 2025
@aarnphm aarnphm force-pushed the feat/jump-forward-structured-outputs branch from a1048e6 to 236830d Compare April 13, 2025 02:01
@mergify mergify bot removed the needs-rebase label Apr 13, 2025
@aarnphm aarnphm force-pushed the feat/jump-forward-structured-outputs branch from 236830d to a97b172 Compare April 17, 2025 19:04
@mergify Mergify
Copy link

mergify bot commented Apr 17, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @aarnphm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin Awaiting requested review from mgoin mgoin will be requested when the pull request is marked ready for review mgoin is a code owner

@russellb russellb Awaiting requested review from russellb russellb will be requested when the pull request is marked ready for review russellb is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon will be requested when the pull request is marked ready for review WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat will be requested when the pull request is marked ready for review robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill will be requested when the pull request is marked ready for review njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 will be requested when the pull request is marked ready for review ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac will be requested when the pull request is marked ready for review comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat will be requested when the pull request is marked ready for review alexm-redhat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@russellb russellb

@WoosukKwon WoosukKwon

Labels
needs-rebase v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarnphm @russellb @WoosukKwon